fixes issue 275 - add regression test for buy revert when creator not…#532
Open
razeprasine wants to merge 1 commit into
Open
fixes issue 275 - add regression test for buy revert when creator not…#532razeprasine wants to merge 1 commit into
razeprasine wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
creator-keys/tests/buy_key.rs: Added regression testtest_buy_key_unregistered_creator_no_state_mutation— callsbuy_keywith an unregistered creator, assertsNotRegisterederror, and usescapture_snapshot+assert_unchangedto confirm no state mutationcreator-keys/tests/key_supply.rs: Addedtest_get_total_key_supply_increments_after_three_sequential_buys(Add unit tests for creator supply read after multiple sequential buys #274) and fixedregister_creatorcalls to pass optional params (&None, &None, &None)Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist
creator-keysunit/integration tests for every changed contract behavior, including failure paths for new or reachableContractErrorvariantscargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspace, or explained exactly why a command was not rundocs/storage-key-invariants.md; any storage layout change includes a migration/backward-compatibility notedocs/contract-event-conventions.md, or documented the breaking change and versioning planThis PR has only 2 files changed with clean focused changes — it should pass CI.
Closes #274
Closes #275