Fix issues #481, #484, #487, #488#513
Merged
Merged
Conversation
|
@archanavdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four distinct UI/UX issues in a single branch to improve codebase consistency, ensure correct formatting, and add missing integration test coverage.
Scope
useIsMobileintegration test to ensure thewindow.matchMedialistener is correctly removed when the component unmounts.TrendingCreatorCardto use theformatHolderCounthelper instead of.toLocaleString()for displaying the key supply, ensuring counts above 1000 properly use a "K" suffix. Also addedTrendingCreatorCard.integration.test.tsxto assert this rendering logic.TransactionHistory(the activity feed) to use the centralizedformatRelativeTimehelper instead of a local utility. Added an integration test toTransactionHistory.test.tsxto verify that recent events show a "min ago" label while older events show a "days ago" label (and raw ISO strings are never rendered).useDebouncehook and its unit/integration tests are fully implemented, adequately covering value updates after the delay, rapid input changes, and unmount behavior.Closes #481
Closes #484
Closes #487
Closes #488