Repository navigation
Reject incorrect lengths in direct ISBN validators - #1
Merged
Merged
Conversation
ctoth
force-pushed
the
modernize/task6-isbn_utils
branch
from
October 20, 2026 23:53
4fd7ab3 to
1808149
Compare
ctoth
marked this pull request as ready for review
October 21, 2026 03:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct ISBN validators accepted incorrect lengths, and ISBN-13 raised IndexError for an empty string. Require ten or thirteen characters before checksum validation and add regression coverage. Declare the existing test runner with a Python 3.8 compatible lower bound.
Validation: regressions reproduced seven failures before the fix; all 12 tests pass on Python 3.8 and 3.13. Pyright and Ruff pass.