Skip to content

Fix order of the endpoints[] array - #190

Merged
ac000 merged 1 commit into
masterfrom
ep-order
Jun 24, 2026
Merged

ac000 merged 1 commit into
masterfrom
ep-order

Conversation

@ac000

@ac000 ac000 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

At somepoint the order of the endpoints[] array got out of whack with the mtd_api_endpoint enum.

While the order doesn't technically matter due to using array index designators, it's best to keep the two in the same order for maintainability.

Assisted-by: GitHub Copilot:claude-opus-4.5

Copilot AI review requested due to automatic review settings June 24, 2026 19:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorders entries in the endpoints[] designated-initializer table to match the ordering of the mtd_api_endpoint enum (defined in include/libmtdac/mtd.h), improving maintainability/readability of the endpoint registry.

Changes:

  • Moved the “Individuals Reliefs” endpoint block to appear after “Individuals Pensions Income”, matching enum order.
  • Moved the “Individuals State Benefits” endpoint block to follow the reliefs block, matching enum order.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/api_endpoints.h Outdated
At somepoint the order of the endpoints[] array got out of whack with
the mtd_api_endpoint enum.

While the order doesn't technically matter due to using array index
designators, it's best to keep the two in the same order for
maintainability.

Assisted-by: GitHub Copilot:claude-opus-4.5
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ac000
ac000 merged commit bd58f01 into master Jun 24, 2026
8 checks passed
@ac000
ac000 deleted the ep-order branch June 24, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants