Repository navigation
Conversation
Currently I quite often make changes that break ABI, such as updating enums in the middle. But rather than continuously bumping the MAJOR version, I'd rather just bump the MINOR. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull request overview
Updates the library’s shared-object versioning scheme so the ELF SONAME tracks MAJOR.MINOR instead of only MAJOR, aligning runtime linkage with the project’s intent to bump MINOR for ABI breaks.
Changes:
- Change
SOVERfrom$(MAJOR)to$(MAJOR).$(MINOR)for SONAME generation. - Derive
VERSIONfromSOVERso the output filename remainsMAJOR.MINOR.PATCH(+...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently I quite often make changes that break ABI, such as updating enums in the middle.
But rather than continuously bumping the MAJOR version, I'd rather just bump the MINOR.