Repository navigation
Fold poisons into the Potions trade filter and rename Misc/Gems - #11
Merged
absol89 merged 1 commit intoOct 7, 2026
Merged
Conversation
The trade picker drops its separate Poisons filter; poisons already show under Potions. The Misc/Gems filter is now labelled Misc (soul gems still appear there). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SSW5HGXzi9kAVm4zdsSaid
absol89
marked this pull request as ready for review
October 7, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the trade item picker had separate Potions and Poisons filters, and the last filter was labelled "Misc/Gems".
After: there is no Poisons filter; poisons appear under Potions. The last filter is labelled "Misc" and still includes soul gems.
How:
poisonsis removed from the selectabletradeCategoriesbut kept as an item category that the Potions filter matches. The English label formiscchanges to "Misc". The trade UI test now also checks that Poisons is not a selectable filter (15/15 pass locally).🤖 Generated with Claude Code
https://claude.ai/code/session_01SSW5HGXzi9kAVm4zdsSaid
Generated by Claude Code