feat(events): render json-layouts/json-values as a table by default (FT-1970)#45
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis pull request introduces conditional output formatting for the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/commands/events/events.test.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. src/commands/events/index.tsESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox. Comment |
Summary
events json-layoutsandevents json-valuesprinted the raw columnar API object ({columnNames, columnTypes, rows}), which is hard to read. They now mirror the existingevents list/historypattern and render a proper table by default:json-layouts:key | value_type | last_event_at;json-values:value | last_event_at)-o json→ a clean array of row objects--raw→ the columnar{columnNames, columnTypes, rows}object (unchanged escape hatch)Client-side filters (
--match/--top-level/--max-depth) still run first on the columnar data, then conversion — so filtering + table compose. Reuses the existingcolumnarToRowshelper; no new abstractions.Bumps CLI version to 1.10.0.
JIRA: FT-1970
Test Plan
--rawkeeps the columnar shape (both commands)abs --profile latam events json-layouts --source unit_goal_property --phase after_enrichment --source-id 164 --from 14d --match segment_flightrenders a table;--rawstill returns columnarSummary by CodeRabbit
Release Notes
New Features
Tests
Chores