You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1.8.0 was published from the #43 merge commit, which merged through the queue before#42. Because the publish workflow builds from the merge commit, npm 1.8.0 shipped the events feature only — the metrics feature landed on main afterward and was never published (its publish run failed on the duplicate 1.8.0). Bumping to 1.9.0 off current main (which now contains both features) publishes a clean release with everything.
Also adds CLAUDE.md documenting the build/test/lint commands and the release process — including the multi-PR merge-order gotcha that caused this — so it doesn't recur.
Test Plan
Version bumped 1.8.0 → 1.9.0 (minor)
No source changes; both features already verified on main
After merge: npm view @absmartly/cli version → 1.9.0, and the 1.9.0 tag/commit includes both src/core/metrics/filter.ts and src/core/events/json-filter.ts
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5a6eaf56-0182-44c1-8792-3124533ed24e
📥 Commits
Reviewing files that changed from the base of the PR and between fdd56bc and 646eebc.
📒 Files selected for processing (2)
CLAUDE.md
package.json
Walkthrough
This PR adds CLAUDE.md, a contributor guide documenting the development workflow for the @absmartly/cli repository. The guide covers build, test, typecheck, lint, and format procedures; branching and worktree conventions; and detailed release/versioning rules explaining release-please automation on main, publishing conditions based on package version, and multi-PR merge-queue enqueuing with verification steps. The PR also bumps the package version from 1.8.0 to 1.9.0 in package.json.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
absmartly/cli-ts#27: Both PRs bump the CLI package version in package.json as part of release versioning workflows.
absmartly/cli-ts#20: Both PRs modify the version field in package.json within release/versioning processes managed by release-please automation.
Poem
🐰 Hop along, dear contributors, let's make it clear— Build and test and format true, then release with cheer! Merge queues dance in graphql grace, versions bump on main, With CLAUDE's wisdom in your pace, no workflow shall be plain!
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title 'chore(release): bump cli to 1.9.0' is fully related to the main change in the changeset—it accurately summarizes the primary objective of bumping the package version from 1.8.0 to 1.9.0 for release purposes.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch chore/release-1.9.0
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases 1.9.0, which contains both recently merged features:
feat(metrics): client-side list filters(FT-1966, feat(metrics): add client-side list filters (FT-1966) #42)feat(events): json-layouts/json-values --match/--top-level/--max-depth filters(FT-1969, feat(events): add client-side --match/--top-level/--max-depth filters to json-layouts/json-values (FT-1969) #43)Why this is needed
1.8.0was published from the #43 merge commit, which merged through the queue before #42. Because the publish workflow builds from the merge commit, npm1.8.0shipped the events feature only — the metrics feature landed onmainafterward and was never published (its publish run failed on the duplicate1.8.0). Bumping to1.9.0off currentmain(which now contains both features) publishes a clean release with everything.Also adds CLAUDE.md documenting the build/test/lint commands and the release process — including the multi-PR merge-order gotcha that caused this — so it doesn't recur.
Test Plan
mainnpm view @absmartly/cli version→1.9.0, and the 1.9.0 tag/commit includes bothsrc/core/metrics/filter.tsandsrc/core/events/json-filter.tsSummary by CodeRabbit
Chores
Version Update