NOISSUE - Add server-side ordering for Atom lists - #83
Open
fbugarski wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds server-side ordering support for Atom list queries.
What does this do?
Adds GraphQL
orderanddirarguments for Atom list queries:The ordering is applied in the backend before pagination, so list pages can be
globally sorted without MG UI fetching and sorting full datasets on the frontend.
This also updates the Atom app CRUD list UI to expose sort controls for the supported list pages.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes. Added
tests/m44_list_sorting.rsfor server-side list ordering and updated existing tests for the new list params.Verified locally:
cargo +1.89.0 checkcargo +1.89.0 test --no-runcd app && pnpm run lintcd app && pnpm run testcd app && pnpm exec tsc --noEmit --incremental falseDid you document any new/modified features?
No separate documentation update. This PR updates the GraphQL schema and Atom app UI behavior directly.
Notes
This is the backend prerequisite for the MG UI ordering fix. MG UI should forward
order/dirto Atom instead of doing frontend full-list sorting.