Skip to content

Update compilation guide - #720

Merged
abrignoni merged 2 commits into
abrignoni:mainfrom
Rugikex:fix/compilation-improvements
Jul 30, 2026
Merged

Update compilation guide#720
abrignoni merged 2 commits into
abrignoni:mainfrom
Rugikex:fix/compilation-improvements

Conversation

@Rugikex

@Rugikex Rugikex commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This PR fixes a compilation issue with newer scripts using 'zoneinfo'.
It also updates the 'Compile to executable' section in the README to match the clear, OS-separated instructions found in iLEAPP.

@Rugikex

Rugikex commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Hi, I noticed the files have been updated since then. Is this PR still needed, or should I close it?

@abrignoni

Copy link
Copy Markdown
Owner

Thanks for checking back @Rugikex, and sorry for the slow reply! 🙏 Here's where things stand — it's a split answer:

The zoneinfo part is no longer needed. It has since landed on main and is now present in all six spec files (including the _Linux and _macOS ones that didn't exist when you opened this). That's also why the PR is showing conflicts.

The README part is still very much wanted — arguably more than when you opened it. What's on main today is wrong: it tells people to run pyinstaller --onefile aleapp.spec, but there's no aleapp.spec at the repo root anymore (they all moved to scripts/pyinstaller/), and we've since added OS-specific specs the README says nothing about. So anyone following it hits a wall. Your OS-separated layout is exactly the right fix, and dropping --onefile/--noconsole is correct too since the specs already set those themselves.

If you're up for rebasing on current main and keeping just the README change, three small things to fix:

  1. Drop the leading separator\scripts\pyinstaller\aleapp.spec and /scripts/pyinstaller/... are absolute paths from the drive/filesystem root. They should be relative: scripts\pyinstaller\aleapp.spec / scripts/pyinstaller/aleapp_macOS.spec.
  2. Filename casing — the actual files are aleapp_macOS.spec and aleappGUI_macOS.spec (capital OS). aleapp_macos.spec happens to work on macOS's case-insensitive default but breaks on case-sensitive setups.
  3. Add Linux — we now ship aleapp_Linux.spec and aleappGUI_Linux.spec, so a Linux section alongside Windows and macOS would round it out.

No rush at all, and if you'd rather not bother with the rebase just say the word and we'll pick it up from here with credit to you. Either way, thanks for spotting the zoneinfo crash and for circling back on this. 🚀

@Rugikex
Rugikex force-pushed the fix/compilation-improvements branch from 0b8e828 to bc9c720 Compare July 29, 2026 07:34
@Rugikex Rugikex changed the title Fix zoneinfo to hiddenimports and update compilation guide Update compilation guide Jul 29, 2026
@Rugikex

Rugikex commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I have updated the README according to your feedback. Let me know if everything looks good now!
Just a heads up: Ileapp's README was updated in the meantime, but I kept the older version here.

@abrignoni
abrignoni merged commit 357c2c0 into abrignoni:main Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants