chore(tools): remove dead local Nx plugins superseded by @nx-devkit/typescript - #228
Conversation
…ypescript After the abapify#221 migration, all build/test inference comes from @nx-devkit/typescript (tsdown.config.ts -> build, vitest.config.ts -> test, tsc -> typecheck). The local plugin implementations were no longer registered in nx.json and are deleted: - tools/nx-tsdown, tools/nx-vitest, tools/nx-typecheck, tools/nx-sync tools/nx-npm-trust stays — its npm-trust-check target is still wired into publish.yml preflight, and @nx-devkit/prepare-for-release does not cover the read-only trust/pack checks. Also: - bump @nx-devkit/typescript 0.2.8 -> 0.2.17 - drop stale tsconfig project references and the dead tools/eslint-rules lint input (directory does not exist) - update README, ts-xsd AGENTS, and nx-monorepo-setup rule to name the inference plugin actually in use Verified: nx show projects (46), nx build+test @abapify/adt-lint. Closes bead ac-fvl. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
✅ Deploy Preview for adt-cli canceled.
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (40)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MergerNeeds Review Non-trivial Nx plugin removals, dependency changes, and lockfile updates have no recorded CI run. The claimed build/test/typecheck inference therefore lacks automated verification before merge. |
codeant-ai
Bot
added
the
size:XS
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a clean refactoring PR that successfully consolidates build/test/typecheck inference to @nx-devkit/typescript by removing dead local Nx plugins. The changes are consistent across documentation, configuration, and dependency updates. The version bump from 0.2.8 to 0.2.17 and the removal of stale tsconfig.json references complete the cleanup appropriately. No defects identified that would block merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
discrepancy_report.md was a one-off May audit (Jules). Its findings are now either resolved by the spec reconciliation work (abapify#227) or tracked as live beads: thin-adapter violation in sap_connect (ac-b5o) and the adt-cli dependency leak in adt-mcp (ac-c07). Also gitignore .beads.gate.lock — runtime artifact of the bead gate. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
1 participant
User description
Summary
tools/nx-tsdown,tools/nx-vitest,tools/nx-typecheck,tools/nx-sync) — all build/test/typecheck inference comes from@nx-devkit/typescriptsince chore(nx): migrate to @nx-devkit/typescript plugin #221@nx-devkit/typescript0.2.8 → 0.2.17tools/nx-npm-trust— itsnpm-trust-checktarget is still wired intopublish.ymlpreflight and has no npm-package equivalenttsconfig.jsonproject references, deadtools/eslint-ruleslint input, and update README / agent rules to name the plugin actually in useTest plan
nx show projects— 46 projects, inference intactnx run-many -t build test --projects=adt-lint— greenCloses bead
ac-fvl.Generated with Devin
Summary by cubic
Deletes four dead local Nx plugins (
tools/nx-tsdown,tools/nx-vitest,tools/nx-typecheck,tools/nx-sync) whose build, test, and typecheck target inference is now handled by@nx-devkit/typescript, and bumps that dependency from 0.2.8 to 0.2.17. Also drops the staletools/eslint-ruleslint input and outdatedtsconfig.jsonproject references, updates the README and agent rules to name the plugin actually in use, removes the one-offdiscrepancy_report.mdaudit, and ignores the.beads.gate.lockruntime artifact.Refactors
tools/nx-npm-trustis kept because itsnpm-trust-checktarget is still wired into thepublish.ymlpreflight and has no equivalent in@nx-devkit/typescript.Written for commit dfa200c. Summary will update on new commits.
CodeAnt-AI Description
Replace redundant local Nx plugins with the shared TypeScript inference plugin
What Changed
@nx-devkit/typescript@nx-devkit/typescriptto version 0.2.17 and removed stale project references and lint inputsImpact
✅ Consistent Nx build, test, and type-check targets✅ Fewer obsolete workspace tools to maintain✅ Clearer Nx setup documentation💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.