fix(adt-flow): expose ownership divergence path - #217
Conversation
Keep the existing hash-verification boolean contract for fast paths, while including the first divergent owned-file path in working_tree_diverged diagnostics.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
✅ Deploy Preview for adt-cli canceled.
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
MergerWaiting for CI and review to complete. |
codeant-ai
Bot
added
the
size:S
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds a helper that identifies the first missing or hash-mismatched owned file. Indexed ownership errors now include that file’s path, and the service test checks the error details. ChangesIndexed ownership divergence reporting
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change adds the divergent file path to ownership errors without an identified regression; it is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This diagnostic improvement enhances error reporting by exposing the specific divergent file path in working_tree_diverged errors. The refactoring is well-structured: findDivergedOwnedPath provides the detailed path information, while verifyOwnedHashes remains as a boolean convenience wrapper. The test coverage validates the new diagnostic information is correctly included in error details. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
CodeAnt Nitpicks1 code suggestion1. A local edit after this scan can be missed, then later planning and applying writes can overwrite that edit with fetched content.Race condition · |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 416 |
| Duplication | 52 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
User description
Summary
working_tree_divergeddiagnostics.Verification
bunx vitest run --config packages/adt-flow/vitest.config.ts packages/adt-flow/tests/service.test.ts --testNamePattern "fails before source reads when an indexed file was edited locally"NX_DAEMON=false bunx nx run adt-flow:test --output-style=staticNX_DAEMON=false bunx nx run adt-flow:build --output-style=staticNo checkout, materialization, or recovery behavior changes; this is diagnostic-only.
Summary by cubic
Exposes the first diverged owned-file path in
working_tree_divergederrors so callers can identify which file broke ownership. The existing boolean verification contract is kept for fast-path validation, and a regression test covers an edited indexed source file. No checkout, materialization, or recovery behavior changes.Written for commit d6f5483. Summary will update on new commits.
CodeAnt-AI Description
Show which indexed file caused a working-tree divergence
What Changed
Impact
✅ Clearer checkout divergence errors✅ Faster diagnosis of locally edited files✅ Preserved local changes during failed checkout💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit