Skip to content

Ecosystem review: catalogue contract gate, current pins, corrected prose - #66

Merged
oblomov-dev merged 7 commits into
mainfrom
claude/repo-structure-analysis-6t4t6x
Aug 31, 2026
Merged

Ecosystem review: catalogue contract gate, current pins, corrected prose#66
oblomov-dev merged 7 commits into
mainfrom
claude/repo-structure-analysis-6t4t6x

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

Six commits from the 2026-08-30 ecosystem review:

  • scripts/check-catalogue-contract.mjs — byte-identical copy of the new shared checker (source: abap2UI5/.github/shared/), pinning this repository's published catalogue.json shape; wired into check:catalogue.
  • Pins current: @abap2ui5/linter + @abap2ui5/render-runtime move from the ^0.4.1 line (which could never reach 0.5.x/0.6.x) to ^0.6.1 — 0.6.0/0.6.1 reached npm on 2026-08-30, this is the Monday cron's move a few days early, same gate (32 files, render included, no findings). Framework pin 1.143.0 → 1.144.0, @abaplint/cli lock → 2.120.39.
  • Prose corrected: the abaplint config comments no longer name the removed check:chains/chain-format.mjs or claim the hand-written overview app is generated; the README workflow table's "the two lists are the same list" claim is scoped to what is actually true (the two missing check-* rows are in, the build jobs are named as such); timeout ceiling on the deploy job.

Validated: full npm run check chain green on the new pins.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc


Generated by Claude Code

claude added 6 commits August 30, 2026 21:25
0.6.0 and 0.6.1 reached npm on 2026-08-30 (16:48 / 17:47 UTC); the
weekly bump-linter cron would have delivered them next Monday - the
same cadence that merged 0.4.0 and 0.4.1 within minutes of their
publish on 2026-08-25 (PRs #60/#61). This is that bump a few days
ahead of the cron, with the same gate: abap2ui5lint ran green over the
full catalogue (32 files, render included, no findings) on the matched
pair.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
scripts/check-catalogue-contract.mjs is the byte-identical copy of
abap2UI5/.github/shared/check-catalogue-contract.mjs (check:shared
gates it, sync-shared pulls it): it pins the published shape of this
repository's catalogue.json - the interface mcp-server, the
vscode-extension and the playground parse from GitHub main - including
the deliberate divergences between the three sample repositories.
Wired into the catalogue check so it runs wherever the catalogue is
verified. Green against the current catalogue.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
Same move as in samples: the pin trailed the family at 1.143.0 and the
@abaplint/cli lock at 2.120.24; both move to the current state
(1.144.0, 2.120.39) a few days ahead of their scheduled bumps. The
full check chain ran green - abaplint against the 1.144.0 clone, the
abap2UI5 linter with render, every generator and catalogue check.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
The chain-layout comment named npm run check:chains and
scripts/chain-format.mjs - both gone since the linter's
chain-house-layout took the job over; it now names that rule. The
overview-app comment claimed the app is generated by npm run
overview - this repository has neither the script nor a generator:
the overview is hand-written and held to its shape by
scripts/check-overview.mjs, which is what the comment says now.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
abap2UI5 sets timeout-minutes on all of its jobs and most repositories
follow; this one had jobs without a ceiling, so a hung run could hold
its slot (and in the publish workflows, the downstream pipeline) for
GitHub's six-hour default. Values follow the job's real budget.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
'Every check below has a workflow, and every workflow is a step of npm
run check - the two lists are the same list' was disproved by its own
table in both directions: create-package-branches and deploy-web are
build-and-publish jobs that are not steps of npm run check, and
check-framework-pin and check-family-nav are steps with workflows the
table did not list. The two missing rows are in, and the claim is
scoped to the check-* rows with the build jobs named as what they are.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
Copilot AI lite review requested due to automatic review settings August 31, 2026 01:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Re-lands the badge refresh the check-abap2UI5 workflow pushed onto this
branch (91 -> 111 rules passed, following the linter bump below): a head
pushed by github-actions[bot] leaves every workflow run waiting for
manual approval, so the same change lands again under a human account.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BuzK8EC2CdQ5PJ6YCdfKJc
@oblomov-dev
oblomov-dev force-pushed the claude/repo-structure-analysis-6t4t6x branch from e34f76b to 3dfd2b3 Compare August 31, 2026 02:04
@oblomov-dev
oblomov-dev merged commit e74677c into main Aug 31, 2026
24 checks passed
@oblomov-dev
oblomov-dev deleted the claude/repo-structure-analysis-6t4t6x branch August 31, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants