The .nvmrc CONVENTIONS section 4 asks for - #64
Merged
Conversation
Section 4 is one sentence: "`engines.node` is `>=22` and `.nvmrc` says `22`." The first half was here; the second was missing — in seven of the nine repositories, which is what happens to a rule with no gate behind it. Section 4 is the only section of CONVENTIONS.md that `conventions-gate.mjs` does not touch: it decides workflow file names (§2), AGENTS.md/CLAUDE.md pairing (§6) and .gitattributes (§6), and nothing at all about the toolchain. The file records what is already true rather than proposing a move: CI runs Node 22 here and `engines.node` already says `>=22`. What it changes is that `nvm use` picks that version instead of whatever the shell happened to have. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146Q9UP9JavNhdDd8bqdQik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds
.nvmrccontaining22.Why
CONVENTIONS section 4 is one sentence: "
engines.nodeis>=22and.nvmrcsays
22." The first half was here; the second was missing — and not only here:seven of the nine repositories had no
.nvmrc, onlyabap2UI5andlinterdid.
That is what happens to a rule with no gate behind it, which CONVENTIONS itself
names as the failure mode ("prose is not a thing that fails a pull request").
Section 4 is the one section
conventions-gate.mjsdoes not touch at all: itdecides workflow file names (§2), AGENTS.md/CLAUDE.md pairing (§6) and
.gitattributes(§6), and nothing about the toolchain.Why it is safe
The file records what is already true rather than proposing a move: CI here
already runs Node 22 and
engines.nodealready says>=22. What changes is thatnvm usepicks that version instead of whatever the shell happened to have.npm run checkpasses with the file in place.Generated by Claude Code