Four formatting drifts, ported from the samples-controls pass - #63
Merged
Conversation
The same cleanups that ran over samples-controls' 637 ports. Nothing changes what an app does. 1. The check_on_init( ) fork - 1 class. check_on_init( ) true implies check_on_navigated( ) true, so an init branch whose only statement is view_display( ) has an ELSEIF twin doing the same thing. 2/3. No findings here: no t_arg list was wrapped onto a wrong column, and the one VALUE table of three or more rows is already column-aligned. 4. Statements that fit 120 characters on one line - 55 of them. Excluded by construction: the view chain, wrapped t_arg lists, classic and RAP statements whose sections carry meaning stacked (this repository is where that mattered - COMMIT ENTITIES ... FAILED ... REPORTED had to be exempted), and string templates split with && - joining one made abaplint ask for reduce_string_templates, which is how the exemption was found. Also carries the shared view-chain-layout skill over from its source in abap2UI5, where it grew a seventh rule: a wrapped t_arg list hangs under its FIRST element. The ABAP style itself stays documented once, in samples/AGENTS.md, which this repository defers to and which is updated in the same round. Gates: lint, check:abap2ui5, overview, keywords, abapdoc, samples-md, catalogue, prose, family-nav, app-rules, pin - all green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XTmU5ANuAvvSTEUdqUpVag
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same cleanups that ran over samples-controls' 637 ports. Nothing changes what an app does.
What changed
1. The
check_on_init( )fork — 1 class.check_on_init( )being true impliescheck_on_navigated( )is true (every path to an instance's firstmain( )sets that flag), so an init branch whose only statement isview_display( )has anELSEIFtwin doing the same thing.2 and 3 — no findings here. No
t_arglist was wrapped onto a wrong column, and the oneVALUEtable of three or more rows is already column-aligned.4. Statements that fit 120 characters on one line — 55 of them.
This repository is where two exemptions were found
The collapse rule had to learn two things here, and both are now exempt everywhere:
COMMIT ENTITIES … FAILED … REPORTEDreads stacked for the same reasonEXPORTING/EXCEPTIONSdoes — the sections are structure, not parameters.&&. Joining one made abaplint ask forreduce_string_templates(app 007), which is exactly how the exemption was found rather than guessed.Also in this PR
The shared
view-chain-layoutskill, carried over from its source in abap2UI5 where it grew a seventh rule: a wrappedt_arglist hangs under its first element.The ABAP style itself stays documented once, in
samples/AGENTS.md, which this repository defers to and which is updated in the same round (abap2UI5/samples#807).Verification
lint,check:abap2ui5,check:overview,check:keywords,check:abapdoc,check:samples-md,check:catalogue,check:prose,check:family-nav,check:app-rules,check:pin— all green.🤖 Generated with Claude Code
https://claude.ai/code/session_01XTmU5ANuAvvSTEUdqUpVag
Generated by Claude Code