Unfreeze the linter pin, and add the workflow that keeps it moving - #59
Merged
Merged
Conversation
`npm ci` reads package-lock.json, and the lock here sat at @abap2ui5/linter 0.2.2 while two releases went by. The range made that permanent rather than accidental: `^0.2.2` means `>=0.2.2 <0.3.0`, so 0.3.0 could not arrive even through a fresh install, and nothing in this repository was ever going to move it. The gate stayed green the whole time and said less every release without saying so. Moved to 0.3.0 and verified before committing: `npx abap2ui5lint` over the full corpus, no findings. The render runtime rides along deliberately - the two are ONE release with one version (the linter's metadata snapshot is generated from exactly the @openui5 version pinned over there), so bumping one alone is the drift that splitting them was allowed on condition of avoiding. The bump workflow is the part that matters more than the number. It is samples-controls' one, adapted to this repository's own gate: weekly, tracking `latest` rather than the declared range, running the linter over the corpus BEFORE the PR exists so a rule regression fails the bump instead of landing on main. Scheduled after samples-controls' so the three corpora move in a known order. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E8iuqE8QFQXpb1LzHQ3Ym5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin was frozen, and the range made it permanent
npm cireadspackage-lock.json, and the lock here sat at@abap2ui5/linter0.2.2 while two releases went by. That was not a missedweek —
^0.2.2means>=0.2.2 <0.3.0, so 0.3.0 could not arrive even througha fresh
npm install, and nothing in this repository was ever going to moveit. Sibling
samples-controlshas run 0.3.0 since its release and movesweekly.
The gate stayed green the whole time. That is the part worth naming: a green
check-abap2UI5here and a green one there were checking different things, andnothing said so.
What this does
@abap2ui5/render-runtimealong, deliberately — the two are onerelease with one version (the linter's metadata snapshot is generated from
exactly the
@openui5version pinned over there), so bumping one alone isprecisely the drift that splitting them was allowed on condition of avoiding;
bump-linter.yaml, samples-controls' workflow adapted to thisrepository's own gate: weekly, tracking
latestrather than the declaredrange, and running
npm run check:abap2ui5over the full corpus beforethe PR exists, so a rule regression fails the bump instead of landing on main.
Scheduled at 06:47 Mondays, after
samplesandsamples-controls, so thethree corpora move in a known order.
Verified
npx abap2ui5linton 0.3.0 over the full corpus:Also run against the linter's main (92 rules, five of them not yet
published) — likewise clean, so nothing here is waiting on the next release
either.
Generated by Claude Code