Clarify frozen-view-builder linter rule documentation - #209
Merged
Conversation
The rule table described the old builder as something that "matters more than it looks". The linter no longer says it that way: `z2ui5_cl_xml_view` keeps working and is headed for an addon of its own, so the row now says what the finding is really about - none of the rules above it can read that API, so none of them ran - and recommends the switch for what it buys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011qkUxU6fypKKwy1WE8kmDA
There was a problem hiding this comment.
🟡 Changes recommended
The updated documentation line includes speculative future-facing wording and a slightly ambiguous claim that should be made strictly factual and clearer.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the frozen-view-builder rule description in the linter documentation to better explain the technical trade-off of continuing to use z2ui5_cl_xml_view versus switching to z2ui5_cl_ui5_view_builder.
Changes:
- Reworded the
frozen-view-builderrow to emphasize thatz2ui5_cl_xml_viewstill works, but blocks downstream rule evaluation. - Shifted the rationale away from language-model output and toward the linter’s parsing/gating mechanics.
File summaries
| File | Description |
|---|---|
| docs/advanced/linter.md | Refines the explanation of what frozen-view-builder flags and why it affects the rest of the ruleset. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | --- | --- | | ||
| | `unknown-binding-path` | a hand-written `{/TYPO}` the derived model has no path for — the field just stays empty. Inside a bound aggregation a relative `{TYPO}` is resolved against the **row**, so a misspelled column is caught too | | ||
| | `frozen-view-builder` | the class still builds its view with `z2ui5_cl_xml_view`, the frozen predecessor. It matters more than it looks: that API is what nearly all public abap2UI5 material shows, and therefore what a language model writes when asked for an app | | ||
| | `frozen-view-builder` | the class builds its view with `z2ui5_cl_xml_view`, the predecessor. That is fine to keep — it works, and is headed for an addon of its own — but no rule above can read it, so none of them ran: switching to `z2ui5_cl_ui5_view_builder` is what buys the whole gate | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the documentation for the
frozen-view-builderlinter rule to better explain its purpose and the implications of using the older API.Changes
z2ui5_cl_xml_viewis acceptable and maintained, but prevents other linter rules from runningz2ui5_cl_ui5_view_builderis necessary to enable the full suite of linter checksDetails
The updated description more accurately reflects the rule's role in the linter gate system: it's not about discouraging use of the older API, but rather documenting that its use bypasses downstream validation rules. This helps users understand the trade-off when choosing between the two view builder approaches.
https://claude.ai/code/session_011qkUxU6fypKKwy1WE8kmDA