Add EQ support for QuietComfort Headphones (prince) - #36
Open
hieupm2096 wants to merge 1 commit into
Open
hieupm2096 wants to merge 1 commit into
hieupm2096 wants to merge 1 commit into
Conversation
The QuietComfort Headphones expose the same 3-band equalizer register [1.7] as qc45/qc_ultra2/qc_earbuds, but the prince device config never declared the feature, so bosectl/bmapctl reported EQ as unsupported. Verified against firmware 1.0.6-80+f5f219b: - GET [1.7] returns 4-byte groups [min, max, current, band_id], range -10..+10 - SETGET [1.7] with [value, band_id] writes one band per packet - a write round-tripped through a subsequent read Adds the eq address in the Python, Rust, and C++ device configs, a Python config test, a Rust config assertion, and a C++ has_feature test. Updates the README device table and the prince/architecture docs to list EQ as verified instead of unverified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prince,0x4075) expose the same 3-band EQ register[1.7]asqc45/qc_ultra2/qc_earbuds, but theprincedevice config never declaredeq, sobosectl/bmapctlreported EQ as unsupported on real hardware.eqaddress to the Python, Rust, and C++ device configs, and marks EQ as verified in the docs.Changes
python/pybmap/devices/qc_prince.py,rust/src/devices.rs,cpp/src/devices.h: declare EQ atAddr(1, 7)(parse_eq/build_eq_band).python/tests/test_qc_prince.pyconfig suite, a Rust config assertion, and a C++prince_has_eqtest.docs/architecture.mdquirks table now list 3-band EQ forprince;docs/quietcomfort-headphones-prince.mdgains an EQ section and drops EQ from the unverified list.Verification
Verified against real hardware: Bose QuietComfort Headphones, firmware
1.0.6-80+f5f219b.[1.7]GET returns 4-byte groups[min, max, current, band_id], signed-10..+10(read returned Bass +6 / Mid +5 / Treble +6).[1.7]SETGET with[value, band_id]writes one band per packet; a write round-tripped through a subsequent read.make test: Python 194 passed / 18 skipped, Rust 75 passed, C++ 64 passed.Device Impact
prince) — EQChecklist
make test)docs/quietcomfort-headphones-prince.mdupdated instead; NOTES.md[1.7]EQ section is device-agnostic