Skip to content

fix: stop queued sections after summary failure - #53

Open
imshah-id wants to merge 1 commit into
aaron-seq:mainfrom
imshah-id:fix/stop-failed-summary-queue
Open

imshah-id wants to merge 1 commit into
aaron-seq:mainfrom
imshah-id:fix/stop-failed-summary-queue

Conversation

@imshah-id

Copy link
Copy Markdown

Description

Closes #49. Stop claiming queued summary sections as soon as a worker fails, preserving the original error and the order/concurrency behavior of successful calls. Requests already started may settle. Updated the development guide to state that boundary.

Validation

  • Both new deferred-response regressions failed before the fix: the mapper started queued callbacks and the actual worker started extra provider requests after reporting PROVIDER_ERROR.
  • npm run verify: lint, typecheck and all 313 tests pass.
  • npm run test:coverage: all 313 tests pass; 94.5% statements and 84.49% branches, above configured floors.
  • Test commands used process-local commit.gpgsign=false for synthetic Git fixture commits; no Git configuration was modified.
  • Chrome APIs and provider fetches were mocked. Browser E2E, real provider calls and manual extension loading were not run.

Risks and rollback

Already-started provider requests are not cancelled and may still complete after the task returns an error. No permissions, provider payloads, settings or persistence formats change. Revert this commit to restore previous scheduling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed sectioned summaries keep launching queued provider requests

1 participant