Repository navigation
Preserve saved preferences when settings reads fail - #42
Merged
Merged
Conversation
Treat an unavailable settings record separately from first-run defaults. Fail closed for notifications and optional history, preserve generated output, prevent replacement writes, and recover options and installation paths. Replace the old default-on-read-error test because that contract caused the reported failure. Reset the local write mock between tests after shuffled execution exposed leakage.
This was referenced Oct 23, 2026
aaron-seq
marked this pull request as ready for review
October 24, 2026 09:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed settings read previously substituted enabled defaults, allowing optional notifications/history or replacement settings writes despite saved opt-outs. This change returns
SETTINGS_UNAVAILABLE, requires readable preferences for optional effects, and preserves generated output with a save warning. Settings startup, reset, and first-install menu setup now handle failures and recovery.Closes #38 · milestone · private dashboard.
Validation performed in this Codex session on Windows / Node 22.18.0:
Assessment, requirement/test map and evidence · continuation checkpoint.
CI must be checked against the current head; final run links are maintained on #38.
No new dependency, permission, schema, provider, backend, or CI/security setting change. No migration; reverting the fix restores the prior failure behavior. Native menu/shortcut/OS-notification verification remains #40, scanner setup #41, CI modernization #32. No live-provider, minimum-Chrome/macOS, or combined UI-draft testing was performed; #39 remains separate. Draft for review; no merge, release or deployment.