feat(list): expose receipt-backed Droid attestation - #122
swaynehales wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7ae7720ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let addressed = ["delivered_to", "mentions"].iter().any(|field| { | ||
| request | ||
| .get(field) | ||
| .and_then(|v| v.as_array()) | ||
| .is_some_and(|values| values.iter().any(|v| v.as_str() == Some(name))) |
There was a problem hiding this comment.
For a normal broadcast, resolve_delivery records every recipient in delivered_to even though the message is not directed to any of them (src/commands/send.rs:311-318). Consequently, an adapter receipt referencing a broadcast makes this predicate true and exposes adapter_attestation: "droid" without an addressed request. Require mention scope (and recipient membership) rather than treating any delivered_to entry as direct evidence.
Useful? React with 👍 / 👎.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
1 participant
Summary
hcom listUserPromptSubmitorStopadapter receiptVerification
cargo fmt --all -- --checkcargo clippy --all-targets --all-features --locked -- -D warningscargo test --all-targets --locked— 2,214 passed; 16 ignoredThis is forgeable same-user local receipt evidence, not authentication. nurmterm owns adapter receipt-schema churn. Human
listcurrently performs two receipt-history lookups per instance; that tradeoff is called out for maintainer review.