Repository navigation
fix(compat): parse the v0.3 REST extended agent card as JSON - #1420
Open
ConnorMoss02 wants to merge 1 commit into
Open
ConnorMoss02 wants to merge 1 commit into
ConnorMoss02 wants to merge 1 commit into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/compat/v0_3/rest_transport.py | 95.63% | 95.60% | 🔴 -0.03% |
| src/a2a/server/cluster/database_event_stream.py | 93.64% | 97.27% | 🟢 +3.64% |
| Total | 93.42% | 93.46% | 🟢 +0.04% |
Generated by coverage-comment.yml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The compat REST client parsed the extended agent card as proto JSON, so security schemes and requirements were lost.
Fix
Parse it with
types_v03.AgentCard.model_validate, as the JSON-RPC client does.Tests
test_compat_rest_transport_get_extended_agent_card_keeps_securityfails on main. It uses the payloadREST03Handlerreturns. The existing extended card test payload is now a valid v0.3 card, since the strict model rejects one with only name and capabilities. 2520 passed.Fixes #1418