Skip to content

fix: Fixes for Jakarta #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
May 14, 2026
+8 −2
Merged

fix: Fixes for Jakarta #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions http-client/src/main/java/org/a2aproject/sdk/client/http/A2AHttpClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public final class A2AHttpClientFactory {
private static final List<A2AHttpClientProvider> PROVIDERS;

static {
PROVIDERS = StreamSupport.stream(ServiceLoader.load(A2AHttpClientProvider.class).spliterator(), false)
PROVIDERS = StreamSupport.stream(ServiceLoader.load(A2AHttpClientProvider.class, A2AHttpClientProvider.class.getClassLoader()).spliterator(), false)
Comment thread
kabir marked this conversation as resolved.
.collect(Collectors.toList());
}

Expand Down Expand Up @@ -85,7 +85,8 @@ public static A2AHttpClient create(String providerName) {
throw new IllegalArgumentException("Provider name must not be null or empty");
}

ServiceLoader<A2AHttpClientProvider> loader = ServiceLoader.load(A2AHttpClientProvider.class);
ServiceLoader<A2AHttpClientProvider> loader =
ServiceLoader.load(A2AHttpClientProvider.class, A2AHttpClientProvider.class.getClassLoader());

return StreamSupport.stream(loader.spliterator(), false)
.filter(provider -> providerName.equals(provider.name()))
Expand Down
5 changes: 5 additions & 0 deletions transport/grpc/src/main/java/org/a2aproject/sdk/transport/grpc/handler/GrpcHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import org.a2aproject.sdk.spec.TaskNotFoundError;
import org.a2aproject.sdk.spec.TaskPushNotificationConfig;
import org.a2aproject.sdk.spec.TaskQueryParams;
import org.a2aproject.sdk.spec.AgentInterface;
import org.a2aproject.sdk.spec.TransportProtocol;
import org.a2aproject.sdk.spec.A2AErrorCodes;
import org.a2aproject.sdk.spec.UnsupportedOperationError;
Expand Down Expand Up @@ -686,7 +687,11 @@ private <V> ServerCallContext createCallContext(StreamObserver<V> responseObserv
}

// Extract requested protocol version from gRPC context (set by interceptor)
// Default to current version since gRPC only handles 1.0 protocol
String requestedVersion = getVersionFromContext();
if (requestedVersion == null) {
requestedVersion = AgentInterface.CURRENT_PROTOCOL_VERSION;
}

// Extract requested extensions from gRPC context (set by interceptor)
Set<String> requestedExtensions = new HashSet<>();
Expand Down