Skip to content

fix: unify HTTP clients#871

Merged
ehsavoie merged 1 commit into
a2aproject:mainfrom
kabir:http-client-unification
May 12, 2026
Merged

fix: unify HTTP clients#871
ehsavoie merged 1 commit into
a2aproject:mainfrom
kabir:http-client-unification

Conversation

@kabir
Copy link
Copy Markdown
Collaborator

@kabir kabir commented May 12, 2026

The compat-0.3 modules can use the main HTTP clients.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the compat-0.3 module by removing the version-specific a2a-java-sdk-compat-0.3-http-client and migrating to the standard a2a-java-sdk-http-client. The changes include updating transport implementations and card resolvers to use A2AHttpClientFactory and the unified A2AHttpClient interface. A critical issue was identified in RestTransportProvider_v0_3 where a potential NullPointerException exists due to an incorrect null check and reassignment logic.

The compat-0.3 modules can use the main HTTP client.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kabir kabir force-pushed the http-client-unification branch from 7c505ce to 7d9e22a Compare May 12, 2026 18:22
@ehsavoie ehsavoie merged commit 4c9dd14 into a2aproject:main May 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants