fix(test): stabilize KafkaReplicationIntegrationTest by waiting for first SSE event#864
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors KafkaReplicationIntegrationTest.java to improve the reliability of the testQueueClosedEventTerminatesRemoteSubscribers test. It replaces the QueueManager polling check with a CountDownLatch that waits for the first event from the subscription, ensuring the connection is established before simulating a queue closure. Review feedback suggests verifying that the first event is a TaskEvent to comply with the A2A specification and updating the error handler to gracefully handle benign stream closure exceptions to prevent test flakiness.
…irst SSE event Replace `awaitQueuePollerStart` (unreliable after re-subscription) with a `CountDownLatch` that fires when the client receives its first event, ensuring the HTTP/SSE connection is fully established before sending the QueueClosedEvent. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
awaitQueuePollerStart(unreliable after re-subscription) with aCountDownLatchthat fires when the client receives its first event, ensuring the HTTP/SSE connection is fully established before sending the QueueClosedEvent.