feat(dockerhub): use OIDC to publish to docker hub when available#101
Merged
Conversation
There was a problem hiding this comment.
Nice work! 😎
I didn't find anything of concern
Risk: 🟢 Low
Risk analysis
The highest scores are for test_coverage and security_impact. Test coverage is strong with new parametrized tests validating each subscription path, though the OIDC flow isn't fully exercised. Security impact is moderate due to the introduction of new authentication methods (OIDC and PAT-based) which, while following best practices, increase the surface area for credential handling and misconfiguration. The change affects generated project templates rather than runtime code, limiting blast radius and operational risk.
Reviewed with 🤟 by Zenable
JonZeolla
enabled auto-merge (squash)
July 23, 2026 19:18
JonZeolla
disabled auto-merge
July 23, 2026 19:22
JonZeolla
enabled auto-merge (squash)
July 23, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonepersonalteamandbusinessTesting
uv run pytest tests/test_cookiecutter.py::test_dockerhub_subscription_prompt tests/test_cookiecutter.py::test_dockerhub_release_authentication --no-covBased on docker/login-action#1048 and Docker OIDC subscription requirements.
PR Description from Zenable
Replace the binary Docker Hub yes/no question with a single
dockerhub_subscriptionchoice (none,personal,team,business) that determines the authentication strategy.none: disables Docker Hub publishing entirelypersonal: uses username/PAT authenticationteam/business: uses short-lived OIDC authenticationTesting
uv run pytest tests/test_cookiecutter.py::test_dockerhub_subscription_prompt tests/test_cookiecutter.py::test_dockerhub_release_authentication --no-covBased on docker/login-action#1048 and Docker OIDC subscription requirements.