Repository navigation
refactor: audit tail — collapse duplicate config type, flatten handler barrel - #65
Merged
Merged
Conversation
The hand-written interface duplicated ~70 keys already enumerated by OpenCodeMemConfigSchema — one type source, no drift.
…rs barrel Dashboard routes already lived in handlers/; the barrel only re-exported them plus two leftover admin handlers. Import origin modules instead.
Native builds fail on exotic platforms and used to fail the whole install. bun:sqlite / node:sqlite users never needed it as a hard dep.
ConnectionManager and VectorSearch each rolled their own prepared-statement WeakMap. plugin.ts only logged-and-rethrew around a static import.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Final batch of the full-codebase audit (the over-engineering pass — every proposal here survived adversarial cross-review against the other audit lenses). Behavior-neutral. Gates green:
format:check+typecheck+ 844 tests passed +build.refactor(config)OpenCodeMemConfiginterface duplicated the zod schema's ~70 keys. Type is nowz.infer<typeof OpenCodeMemConfigSchema>— one source of truth, zero call-site churnrefactor(server)api-handlers.tsbarrel deleted (~90 lines of re-exports + a duplicateApiResponsetype):web-server.tsimports route handlers directly; the two real handlers (cache stats, API status) moved intohandlers/admin.ts; test imports updatedchore(deps)better-sqlite3→optionalDependencies— installs no longer hard-fail where its native build breaks (bun:sqlite/node:sqliteprobe chain unchanged)refactorStmtCachehelper replaces two hand-rolled prepared-statement WeakMaps;plugin.tsre-exportsOpenCodeMemPlugindirectly instead of a try/catch that logs and rethrowsNot done (killed during review — recorded as audited-and-kept)
aiSDK cannot drop-in replace.jsonc-parser: config PUT preserves comments viaapplyEdits— that's a feature.node>=20engine support (CLI is#!/usr/bin/env node).Verification
bun run format:check && bun run typecheck && bun run test && bun run build— all green (844 passed / 1 skipped)plugin-loader-contract.test.tsstill green after theplugin.tssimplification