feat!: rename profile.switch command to profile#54
Merged
Conversation
Renames the ZapScript profile-switch command from **profile.switch to **profile, and the exported constant ZapScriptCmdProfileSwitch to ZapScriptCmdProfile. profile.clear is unchanged. The profiles feature is unreleased in zaparoo-core, so no cards or consumers use the old command name yet. BREAKING CHANGE: ZapScriptCmdProfileSwitch no longer exists; use ZapScriptCmdProfile.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe exported profile command constants in ChangesProfile command constants
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the ZapScript profile-switch command from
**profile.switchto**profile, and the exported constantZapScriptCmdProfileSwitchtoZapScriptCmdProfile.profile.clearis unchanged.The profiles feature is unreleased in zaparoo-core (PR ZaparooProject/zaparoo-core#950), so no cards or consumers use the old command name yet — no alias or deprecation path is included.
BREAKING CHANGE:
ZapScriptCmdProfileSwitchno longer exists; useZapScriptCmdProfile. zaparoo-core's device-profiles branch has been updated to match and currently builds against this via a temporaryreplacedirective, pending a tagged release.Summary by CodeRabbit