Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@jmalcic is attempting to deploy a commit to the Yusuke Iwaki's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright::VERSIONandPlaywright::COMPATIBLE_PLAYWRIGHT_VERSIONare often the same but can differ. The gem version and existing metadata are available through the RubyGems API (without needing to download and unpack or install the gem), but the compatible Playwright version is not. For tools that need to find out which version of Playwright to install given a particular version of the gem, in practice that usually means installing the gem and its dependencies first, even though the gem version is already known (so, you could use the API to fetch the metadata). Since the require for the version file is already present in the gemspec, it would be great to havePlaywright::COMPATIBLE_PLAYWRIGHT_VERSIONin the metadata and be able to get it via the API. Happy to go with a different key name (e.g. could also becompatible_playwright_version).