Skip to content

Fix Android CI host dependencies for FFI generation - #231

Merged
yiguodev merged 1 commit into
mainfrom
codex/fix-android-ci-build
Oct 20, 2026
Merged

yiguodev merged 1 commit into
mainfrom
codex/fix-android-ci-build

Conversation

@yiguodev

Copy link
Copy Markdown
Contributor

Summary

Android CI fails during dart run tool/ffigen.dart because cnativeapi builds its Linux host library before the Android app, and the runner lacks GTK/X11/Xi development packages.

Android job
  Setup Flutter
  + Install Linux host native dependencies
  Generate FFI bindings → build Android app

Install clang, pkg-config, libgtk-3-dev, libx11-dev, and libxi-dev, matching the existing Validate job. Document the host requirements for Android builds.

Evidence

  • Before: Android job 118411664941 fails with pkg-config --cflags gtk+-3.0 x11 xi failed. Replaying the actual native hook with missing package metadata reproduces exit 255.
    After: With those dependencies available in the existing Ubuntu 24.04 ARM64 container, the native hook and complete FFI generation succeed; generated bindings match the checked-in file byte for byte.
  • Build-script suite: 34 passed, 1 skipped. Workflow YAML, dependency-step ordering, and diff checks passed.
  • Full Android release packaging, store upload, and a remote Android build were not run.

Merge Danger

Door: two-way

Blast Radius: CI

Adds package installation to the Android runner before generation; no application or signing changes.

Copilot AI balanced review requested due to automatic review settings October 20, 2026 02:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T02:20:21.031904Z 3e705f9 PR opened
🔒 Security Review ✅ Completed 2026-10-20T02:19:38.808882Z 3e705f9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@yiguodev
yiguodev merged commit 27f06f4 into main Oct 20, 2026
1 check passed
@yiguodev
yiguodev deleted the codex/fix-android-ci-build branch October 20, 2026 02:27
AnatomikPerq added a commit to AnatomikPerq/hp-client that referenced this pull request Oct 21, 2026
Upstream's Android build job; the fork builds Windows only and keeps its own workflow and build notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnatomikPerq added a commit to AnatomikPerq/hp-client that referenced this pull request Oct 21, 2026
…the fork

CLAUDE.md lists what the fork does differently after YuanDevTeam#220-YuanDevTeam#231 (location kept, provider mode opt-in, provider SOCKS/HTTP dropped, User-Agent, live switch with checks, dialing restarts); ROADMAP.md records the owner's decisions and what is left to check live.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnatomikPerq added a commit to AnatomikPerq/hp-client that referenced this pull request Oct 21, 2026
… unchecked

Remnawave with a real panel, the v2rayN User-Agent on existing subscriptions, leastPing and DNS from YuanDevTeam#220, server dialing from YuanDevTeam#230, the live switch with mode checks, layout details and the release build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnatomikPerq added a commit to AnatomikPerq/hp-client that referenced this pull request Oct 21, 2026
…vTeam#231 and profiles

What the release build did in the test VM on 21.10, what is still
unchecked (fast startup, IPv6, Remnawave panel) and what the check found:
Let's Encrypt roots missing for Dart on a fresh Windows, Fragment breaking
REALITY handshakes, a lenient block that outlives logoff after a crash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnatomikPerq added a commit to AnatomikPerq/hp-client that referenced this pull request Oct 21, 2026
Kill switch, профили маршрутизации и режим «Выборочно», апстрим по YuanDevTeam#231
(конфиги провайдера Remnawave), проверка сертификатов через Windows,
Fragment без REALITY, установщик ждёт выхода из приложения, «Подключено»
только после старта Xray. В роадмапе — сводка открытых вопросов.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants