Repository navigation
Allow partial subscription imports and unify download User-Agent - #229
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fb8807e42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b23e9c343a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…nload User-Agent A subscription whose complete configurations partly fail validation now keeps the accepted ones. Every download sends one User-Agent, "v2rayN/<version> <app>/<version> (...)", and the system-browser option is gone. Fork changes on top: the app token stays HyperClient (Remnawave's JSON fallback matches /^v2rayN\/\d+\.\d+\.\d+/ with no minimum version, so 0.1.0-beta.x qualifies), and nodes taken from complete configurations keep the fork's names (remarks, then the tag) and mux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
A single invalid complete configuration could reject an otherwise usable subscription. Import valid configurations individually and keep existing data when none are usable or the validation service fails.
Use one
v2rayN/<OneXray version> <OneXray UA>default for all downloads. Prefill new subscription forms and existing empty UA fields without saving on display or cancel; preserve explicit per-subscription overrides. Remove the global UA selector, its preference, and the unused WebView dependency.Evidence
FormatException; ordinary subscription forms could open with an empty UA field.After: Partial-import coverage verifies accepted graphs and cache preservation; form coverage verifies default values, custom input preservation, and cancel without saving.
flutter analyze --no-pubreported no issues, the layer dependency check passed, andgit diff --checkpassed.Merge Danger
Door: two-way
No database schema changes. Reverting restores the previous import and UA behavior.
Blast Radius: downloads
The shared default UA now includes the compatibility prefix for Geodata and other downloads as well as subscriptions. Explicit subscription overrides remain request-scoped.