Repository navigation
Add support for additional source for video playback - #58
Merged
Merged
Conversation
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Playing YouTube videos keeping running into issues where there's no good format that has both audio & video.
To solve this, this adds support for a additional source URL for video playback, which allows live muxing two input sources - separate video & audio streams.
Related GitHub issues
Yellow-Dog-Man/Resonite-Issues#6970
Notable Changes
--input-slaveoption when additional source is providedTesting
Loaded YouTube videos with separate video & audio streams, which would play both audio & video at the same time!
Backwards Compatibility
This contains breaking changes for the IPC model for loading videos. This doesn't affect any user content, but will affect custom community renderers.