Skip to content

HDCP values are not read correct from the DTS #3

Description

@alahut-janteq

FILE: hdmi/xilinx-hdmirx.c FUNCTION: xhdmi_parse_of
FILE: hdmi/xilinx_drm_hdmi.c FUNCTION: xlnx_drm_hdmi_parse_of

isHdcp14_en = of_property_read_bool(node, "xlnx,include-hdcp-1-4");
isHdcp22_en = of_property_read_bool(node, "xlnx,include-hdcp-2-2");

should be:
const char *str;
of_property_read_string(node, "xlnx,include-hdcp-1-4",&str);
if (!strcmp(str, "false"))
isHdcp14_en = false;
else
isHdcp14_en = true;
of_property_read_string(node, "xlnx,include-hdcp-2-2",&str);
dev_dbg(xhdmi->dev, "xlnx,include-hdcp-2-2 is %s",str);
if (!strcmp(str, "false"))
isHdcp22_en = false;
else
isHdcp22_en = true;

of_property_read_bool returns true if the property is present no matter what the value is. There is not a way to turn this off with an overlay.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions