Repository navigation
Recover Counterparty read slots after cancelled worker runs - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled indexing can stop indefinitely when a cancelled Worker invocation leaves both Counterparty read slots occupied. Later runs then spend the full 15-second timeout waiting for admission. Expire slots at their original read deadline, release them on abort, and make late cleanup harmless to replacement reads. Timeout logs now identify admission, fetch, or body processing.
Validated with a workerd reproduction of abandoned reads, 121 targeted tests, API type/lint checks, and production smoke checks. Deployed API version
93d043f3-c6a3-4dff-b109-c95682e5aec6: the index caught up from block 971882 to 971906, scheduled mempool reads returned to under one second, and Telegram announcements resumed at 20:56 UTC on October 17.