Skip to content

Prepare 0.16.1: fix confirmation status and large funding checks - #593

Merged
droplister merged 3 commits into
mainfrom
fix/funding-confirmation-status
Nov 10, 2026
Merged

droplister merged 3 commits into
mainfrom
fix/funding-confirmation-status

Conversation

@droplister

@droplister droplister commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Prepare 0.16.1 with two funding regressions found while reviewing the 0.16.0 changes.

  1. Core's Bitcoin transaction endpoint can omit confirmations for a confirmed transaction. Preserve that absence and query explorer chain status instead of treating it as zero. Accept an empty asset balance only after verifying ledger indexing and re-reading the balance. A captured public response from the reported XCPETS holder exercises the complete API adapter and funding guard offline.
  2. Internal ZELD inventory checks inherited the external approval screen's 60-input cap, making later clean outputs unavailable. Verify internal inventory and funding in sequential bounded batches. Website approval lookups retain their cap; every internal input remains checked, including later batches.

Validation: reproduced the confirmation regression before the fix; 128 initial focused tests passed. After batching and the captured-response regression, 87 affected composer, funding, ZELD and API-integration tests pass, plus lint/types. Tests cover unknown status, indexing lag, actual attached assets, unresolved unconfirmed ancestry, missing block height, clean funding above 60 inputs, an attached asset in the last batch, and retaining the website input cap. Full CI is required before merge/release. No holder transaction was signed or broadcast.

Reviewed the remaining 0.16.0 runtime changes: MPMA CSV activation/checksum handling, spent-output display and refresh, exhausted-order filtering, settings lifecycle and explicit protocol sort ordering. No additional issue identified in that scoped review; this is not a claim of exhaustive correctness.

@droplister droplister changed the title Fix false funding blocks when Core omits confirmation status Prepare 0.16.1: fix confirmation status and large funding checks Nov 10, 2026
@droplister
droplister merged commit 9156e5a into main Nov 10, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant