Repository navigation
Fix exhausted order-book levels and weekly compose oracle inputs - #591
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly run exposed exhausted open orders appearing as clickable best bids, plus two stale oracle assumptions. Filter orders without positive remaining liquidity before building levels and market statistics. Add a regression test for empty buy and sell orders. The MPMA compose oracle now establishes the table layout from the node network and height, as the wallet does. The on-chain send oracle declines binary memos that the text-only packer intentionally cannot reproduce, instead of encoding their displayed hex as text. Regression coverage pins the failing on-chain sample and verifies hexadecimal-looking text still round-trips exactly. Validation: both PR unit shards and lint/type checking pass. The manual Weekly Tests run passed its full unit suite, all 124 compose-oracle tests, and all 367 fuzz tests. All six browser shards and the complete manual Weekly Tests workflow also passed: https://github.com/XCP/extension/actions/runs/42760076438. No wallet release is included.