Repository navigation
Persist expensive D1 cache results after overload - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The optimized cold collection-candidates request now completes successfully in about 5.2 seconds, but the immediately following cache INSERT was rejected while D1 was still saturated. cached() swallowed that write failure, leaving no cache row and guaranteeing the next caller would recompute the expensive result. This is the overload feedback loop identified in the resource audit.
The durable mode waits 250ms, 750ms, 2s, and 4s between bounded retries. A successful cold response is not returned until its daily cache row is durable. Schema, authentication, and other logic errors are never retried.
Verification
pm test -w xcp-api: 470 passed, 0 failed (34 live-contract tests skipped locally by design)
pm run check: typecheck, ESLint, Prettier, and structure checks passed