Repository navigation
Apply dispenser remaining and count updates independently - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delayed dispenser-close events provide
give_remaining: 0withoutdispense_count. The current handler updates inventory only when both fields are present, leaving stale remaining quantities. Apply each provided field independently, preserve omitted values, and clear the closing timestamp when an update reopens a dispenser.Four real-SQLite sync regressions cover delayed close, status-only updates, quantity-only updates, zero counts, unchanged retries and exact restoration after a reorg. Local validation: 117 compiled API tests, migration checks, three Worker tests, TypeScript and promise lint.
The recovery runbook records the current-set audit and a separate historical repair scope. This PR does not automatically change historical production rows. The observed historical omissions are not attributed to reorgs without evidence.