Repository navigation
Preserve fairminter LP credits with null envelope transaction hashes - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fairminter pool creation emits an end-of-block LP credit with a null envelope transaction hash. The indexer passed that null into
INSERT OR IGNORE, silently dropping both the history row and its balance-trigger effect. Resolve the originating hash fromparams.eventand fail before checkpointing if an LP credit/debit cannot be identified.The database audit found eight omitted locked LP credits. Pool reserves and all 2,505 pool matches agree with Core, but the missing supply affects holder fee analytics. The runbook documents the bounded evidence and a separate guarded historical repair; this PR does not automatically rewrite production history.
Validation: 113 compiled API tests, both D1 migration checks, three Worker tests, TypeScript and promise lint pass. New real-SQLite sync regressions cover a null-envelope credit before OPEN_POOL, a failed post-processing retry, reorg reversal, and stopping on a missing payload identity.