Skip to content

Fix block validation E2E tests on WordPress trunk #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbravobernal wants to merge 2 commits into from
Closed

Fix block validation E2E tests on WordPress trunk #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36035f5
Match editor error notices by text in block validation E2E tests
cbravobernal Oct 21, 2026
e103607
Scope editor notice lookup to the editor content region
cbravobernal Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/e2e/block-testimonial.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,11 @@ test.describe( 'SCF Block > Testimonial', () => {
await publishButton.click();

// Wait for the error notice to appear at the top of the editor
const errorNotice = page.locator(
'.components-notice.is-error .components-notice__content'
);
const errorNotice = page
.getByLabel( 'Editor content' )
.getByText(
'An ACF Block on this page requires attention before you can save.'
);
await expect( errorNotice ).toBeVisible( { timeout: 1000 } );
} );
} );
8 changes: 5 additions & 3 deletions tests/e2e/block-v3-features.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,11 @@ test.describe( 'SCF Block V3 Features', () => {
await publishButton.click();

// Wait for the error notice to appear
const errorNotice = page.locator(
'.components-notice.is-error .components-notice__content'
);
const errorNotice = page
.getByLabel( 'Editor content' )
.getByText(
'An ACF Block on this page requires attention before you can save.'
);
await expect( errorNotice ).toBeVisible( { timeout: 3000 } );
} );

Expand Down
Loading