Repository navigation
Build: Move wp/7.0 to Node 24 and npm 11.18 with the npm v12 supply chain defaults - #84166
Draft
manzoorwanijk wants to merge 8 commits into
Draft
manzoorwanijk wants to merge 8 commits into
manzoorwanijk wants to merge 8 commits into
Conversation
No published package depends on `@wordpress/react-native-*`, and they are the only source of git and remote tarball dependencies on this branch, which the npm v12 supply chain defaults (`allow-git`, `allow-remote`) refuse. Their native toolchain (`react-native`, Appium, Xcode patching) also has no part in a security release. - Exclude `packages/react-native-*` from the workspaces and drop their stale lockfile links, so npm prunes the 811 entries only they needed. No other entry changes version; 36 gain `"dev": true`. - Remove the `native` and `test:native*` scripts, `patch-xcode.js` from `postinstall`, and the patches for `react-native` and `react-devtools-core`, which are no longer installed and would fail `patch-package`. - Remove the `rnmobile-*` workflows and the (already disabled) mobile unit test job.
…ain defaults Trunk publishes `wp/X.Y` releases with its own Node and npm (Node 24, npm `^11.18.0`, soon 12), so the branch must install, build and run Lerna under them. - `.nvmrc` 24.20; `engines` and `devEngines` require Node 24.18 and npm 11.18, mirrored into the lockfile root. - `.npmrc` opts in to `min-release-age`, `strict-allow-scripts` and `allow-git`/`allow-remote`/`allow-file = none`, as on trunk. - `allowScripts` denies every install script in the tree, as on trunk. Without `strict-allow-scripts`, npm 11 ignores `allowScripts` and runs them all. - Remove the one lockfile entry npm marks `"extraneous": true` (`packages/dataviews/node_modules/storybook/node_modules/esbuild`). It has no parent, so npm never prunes it, and the strict preflight rejects it because a dependency without edges never matches a name key (npm/cli#9683). - CI: run on Node 24 only (20 and 22 fail `devEngines`), install npm through the ported `setup-npm` action, and drop the `node_modules` cache from `setup-node`, whose cache-hit path replays `postinstall` scripts.
`storybook-check.yml` installs `@storybook/test-runner` with `npm install --no-save`, which pulls in `@swc/core`. It is not in the lockfile, so the lockfile-based install never saw its postinstall script, and `strict-allow-scripts` failed the Storybook job. Trunk denies it too.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
manzoorwanijk
added
the
[Type] Build Tooling
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #82328, #72973
Moves
wp/7.0to Node 24.20 and npm 11.18 (npm 12 compatible) with trunk's supply chain defaults, and drops React Native from the install.Why?
Trunk publishes
wp/X.Ybranches with its own Node and npm. The React Native packages are unpublished and hold every git and remote tarball dependency, whichallow-git/allow-remote = nonerefuse.How?
packages/react-native-*; removes native scripts, patches and CI jobs. The lockfile drops 811 entries; no version changes..nvmrc,engines,devEngines,.npmrcandallowScriptsas on trunk; drops an orphan lockfile entry (fix(arborist): skip extraneous orphans in strict-allow-scripts gate npm/cli#9683); CI runs Node 24 only and portssetup-npm.Merge order: stacked on #84170; merge that first. Publishing
wp-7.0from trunk also needs #84160.Testing Instructions
Rehearsed trunk's
npm-wpflow (CLI from #84160) against a local Verdaccio and a tagged bare origin, on npm 11.18 and 12.2:npm cipasses with noEALLOW*orESTRICTALLOWSCRIPTS.wp-7.0ones apart from those changes.Use of AI Tools
Claude Code (Opus) wrote the changes and ran the rehearsals; I reviewed them.