Repository navigation
Bump version to 2.1.0-beta.1 - #786
Merged
Merged
Conversation
Download translations: adds bcc, de, es, ja and zh-cn, and the Chromium locales de, es, ja, zh-CN and zh_CN to build.electronLanguages.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First beta of 2.1.0. 25 commits have reached trunk since
v2.0.0, the last one being the 2.1.0 docs update (#777).electron-buildernames the artifacts after the version inpackage.json, so the version has to move before the tag and the artifacts exist. This is a beta, so it does not takereleases/latest.What changes
2.0.0to2.1.0-beta.1inpackage.jsonand both root fields ofpackage-lock.json. No dependency versions change.npm run i18n:downloadrefreshedsrc/languages/. Five locales reach 80% for the first time and now ship:bcc,de,es,jaandzh-cn. The other ten were updated.build.electronLanguagesgains the Chromium locales those catalogs need:de,es,ja,zh-CNandzh_CN.Chromium locales kept (build.electronLanguages): en-US, cs, de, en-GB, en_GB, es, hu, ja, nl, pl, sr, tr, zh-CN, zh_CN
How to test this
Platforms: any for the checks below. macOS and Windows for the signed artifact checks in
RELEASING.mdsection 2, which run on this PR's Buildkite build before the merge.Run from the repository root:
node -e "console.log(require('./package.json').version)"prints2.1.0-beta.1.python3 -c "import json;d=json.load(open('package-lock.json'));print(d['version'], d['packages']['']['version'])"prints2.1.0-beta.1 2.1.0-beta.1.git diff origin/trunk...HEAD -- . ':!src/languages'shows only the three version lines and thebuild.electronLanguageslist.npx electron . --lang=deopens the app in German. Repeat withes,jaandzh-CN; each shows that language, not English.What must not have happened: no dependency version changes in
package-lock.json, and no locale that shipped in 2.0.0 is missing fromsrc/languages/.Risks and limitations
Southern Balochi (
bcc) ships as a right-to-left catalog. Its catalog setstext directiontortl, butbccis missing fromRTL_LANGUAGESinscripts/download-translations.cjs, so the script did not hold it back. Choosing Baluchi in Settings, or an OS that reportsbal, gives a half-mirrored window. Kept on purpose for this beta; the script fix should land before 2.1.0.The translations come from translate.wordpress.org as they stand today. Strings below 100% fall back to English.
Related
Part of the v2.1.0 milestone. The
bccfix is tracked in #787.Review outcome (required, see AGENTS.md)
1 [fix here] · 1 [follow-up]. Neither fixed in this PR.
bccis a right-to-left catalog that was not held back (src/languages/bcc.json,scripts/download-translations.cjs:48). Kept for the beta by the release manager's decision. The fix is to addbcctoRTL_LANGUAGESand re-runnpm run i18n:downloadbefore 2.1.0.text directionentry isrtl, so the next right-to-left locale is not missed the same way, with a case intests/unit/download-translations.test.cjs.Checked with nothing to report: the diff outside
src/languages/is the three version lines plusbuild.electronLanguages; that list matches a fresh calculation from the catalogs; the new catalogs have the same shape as the existing ones and passresolveCatalog; placeholders and HTML tags match the source strings in all 15 catalogs. An older Czech string leaves out%2$s; it predates this branch and is fixed on translate.wordpress.org, not here.1b58aeb/ base6a4df96(trunk);npm run lintclean,npm test2312 pass, 0 fail, 9 skipped; outcome above.🤖 Generated with Claude Code