refactor(skills): narrow discovery descriptions - #453
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wibias
marked this pull request as ready for review
September 13, 2026 08:02
Wibias
enabled auto-merge
September 13, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep discovery metadata focused on ownership, triggers, and boundaries while preserving all executable GitHub Delivery policy in the skill bodies.
ship-gateexecution procedure from the top-leveldescriptionbabysit,babysit-pr, andreview-securityoverride descriptions to compatibility routing onlyWhy
The installed description is part of the model's skill-discovery context. Procedure-level instructions such as
MUST run scripts/...oralways load ... and run ...belong after selection, not in the always-visible routing surface.This is intentionally a discovery-only change. No delivery policy, mutation boundary, ship gate, watch behavior, or security-review procedure is weakened or removed.
TDD evidence
Before the rewrites, the new discovery-frontmatter test failed 4/4 cases on the current descriptions. With the narrowed descriptions, the same test passes 4/4 on the exact branch head.
The full local Windows repository check also caught one PR-caused formatting regression in the existing ship-gate docs contract: the canonical
Watch MUST run scripts/ship-gate.mjs every wakepolicy remained in the SKILL body but was wrapped across a newline, while the old frontmatter had previously supplied the regex-compatible one-line occurrence. The fix keeps the policy in the body and restores the existing assertion without putting executable procedure back into discovery metadata.Two additional local Windows failures are outside the changed paths and are treated as baseline/environmental gaps, not as passing evidence:
verify-pr-headresolves its test fixture/tmp/repoto missingD:\tmp\repo, and the Windows trace-bin package test fails in its npm pack/install probe under the local npm runtime.Changed paths
SKILL.mdoverrides/babysit/SKILL.mdoverrides/babysit-pr/SKILL.mdoverrides/review-security/SKILL.mdtests/discovery-frontmatter.test.mjsRemaining gates
.agentscopy after this upstream change is acceptedDraft until those gates have concrete evidence.