Repository navigation
test: prove VirtualBox methods observe the same VM state - #309
Merged
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286.
Adds opt-in
cross_method_consistency, requiringVBOX_TEST_CROSS_METHOD=1, exact filter, VBoxVMI method and 2 vCPUs. It attaches MachineDebugger and VBoxVMI concurrently to the same paused VBoxHeadless process (test-only combined branchWenzel/virtualbox:vmi/cross-method-test) and:Ordinary
virtualbox_suites exclude it; unfiltered runs without opt-in print SKIPPED; filtered invocation without opt-in fails.integration_filtercovers selection behavior.Verified live:
The 5 GiB run writes/restores page
0x15fff6000above 4 GiB. fmt, clippy -D warnings and integration_filter pass.