Skip to content

DataTables: harden esc() to escape quotes (attribute-safe) #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WebTigers merged 1 commit into from
Aug 17, 2026
+11 −8
Merged

DataTables: harden esc() to escape quotes (attribute-safe) #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions modules/agent/views/scripts/skills/index.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,12 @@ document.addEventListener('DOMContentLoaded', function () {
}
function toast(res) { ((res && res.messages) || []).forEach(function (m) { TigerDOM.toast(m.message, { type: m.class }); }); }

// A skill entry rides on the button as individual data-* attrs (NOT a JSON blob: esc() doesn't
// quote-escape, so JSON in a double-quoted attribute breaks). attr() adds the missing "-escape.
function attr(s) { return esc(s).replace(/"/g, '"'); }
// A skill entry rides on the button as individual data-* attrs (not a JSON blob). esc() is
// attribute-safe (escapes quotes), so it can go straight into the double-quoted attributes.
function entryAttrs(row) {
return ' data-source="' + attr(row.source) + '" data-sourcelabel="' + attr(row.sourceLabel) + '"'
+ ' data-name="' + attr(row.name) + '" data-repo="' + attr(row.repo) + '"'
+ ' data-ref="' + attr(row.ref) + '" data-path="' + attr(row.path) + '" data-url="' + attr(row.url) + '"';
return ' data-source="' + esc(row.source) + '" data-sourcelabel="' + esc(row.sourceLabel) + '"'
+ ' data-name="' + esc(row.name) + '" data-repo="' + esc(row.repo) + '"'
+ ' data-ref="' + esc(row.ref) + '" data-path="' + esc(row.path) + '" data-url="' + esc(row.url) + '"';
}
function readEntry(el) {
return {
Expand Down
8 changes: 6 additions & 2 deletions themes/puma/assets/js/tiger.datatable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,13 @@
return $(selector).DataTable(config);
}

// Small shared escaper for column renderers (prevents XSS from row data).
// Shared HTML escaper for column renderers (prevents XSS from row data). Escapes & < > " ' so it's
// safe for BOTH element text AND attribute values — a render can drop row data straight into a data-*
// attribute without the quotes breaking out (matches tiger.media-picker.js / tiger-upload-list.js).
tigerDataTable.esc = function (s) {
return window.jQuery('<div>').text(s == null ? '' : String(s)).html();
return String(s == null ? '' : s).replace(/[&<>"']/g, function (c) {
return { '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' }[c];
});
};

window.tigerDataTable = tigerDataTable;
Expand Down
Loading