Skills: opt the grid into DataTables assets (fix empty grid) - #131
Merged
Conversation
The Skills manager showed no data: the admin layout loads DataTables + tiger.datatable.js ONLY when a view sets $view->useDataTables (admin.phtml), and Agent_SkillsController::indexAction never set it. So tigerDataTable() was undefined on the page and the grid's init bailed silently — the server was returning a correct 129-row envelope the whole time. - Set $this->view->useDataTables = true in indexAction (matches every other datatable screen, e.g. Access user/org, Code). - SkillsControllerTest: assert the shell dispatches 200, sets its title, and opts into DataTables — the direct regression guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
The Agent Skills grid (
/admin/settings/agent/skills) rendered with no data.Cause
admin.phtmlloads the DataTables library +tiger.datatable.jsonly when a view sets$view->useDataTables(assets are opt-in per screen, like Chart.js).Agent_SkillsController::indexActionnever set it, sotigerDataTable()was undefined and the grid's initreturned silently. The server was returning a correct 129-row envelope all along (verified as the apache user).Fix
Set
$this->view->useDataTables = trueinindexAction— the same opt-in every other datatable screen uses (Access user/org, Code, CMS, Media).Test
SkillsControllerTestdispatches the action (rendering off) and asserts 200 + title +useDataTables === true— the direct regression guard (mirrorsCodeControllerTest).🤖 Generated with Claude Code