Feature/more updates#6
Open
guzmandrade-dev wants to merge 6 commits into
Open
Conversation
added 6 commits
March 31, 2023 13:59
schlotterer
approved these changes
Apr 28, 2023
schlotterer
left a comment
schlotterer
left a comment
There was a problem hiding this comment.
These are good improvements, the comments I made could probably just become new issues to work. @khleomix do we have any kind of plan/roadmap/idea for what this should become?
There was a problem hiding this comment.
Is there a way we can make this a dynamic year within this kind of block based template?
| <!-- /wp:paragraph --> | ||
| </div> | ||
| </div> | ||
| <!-- wp:cover {"minHeight":360,"customGradient":"linear-gradient(253deg,rgba(6,147,227,1) 0%,rgb(84,121,221) 100%)","isDark":false,"align":"full"} --> |
There was a problem hiding this comment.
We can create theme.json level gradients to choose from to make this more consistant and create a css var for easy reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
DESCRIPTION
theme.jsonto version 2 following https://schemas.wp.org/trunk/theme.json and https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-migrations/SCREENSHOTS
OTHER
STEPS TO VERIFY
How do we test this?
The theme still works, and styles on
theme.jsonare now functional.DOCUMENTATION
Will this pull request require updating the theme documentation? Currently on README.md.