Skip to content

panel : mixer : fix popup opening when doing mute_action #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trigg merged 1 commit into from
Jun 21, 2026
Merged

panel : mixer : fix popup opening when doing mute_action #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/panel/widgets/mixer/mixer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,15 @@ void WayfireMixer::reload_config()
return; // no quick_target means we have nothing to change by clicking
}

quick_target->button.set_active(!quick_target->button.get_active());
guint32 id = wp_proxy_get_bound_id(WP_PROXY(quick_target->object));
bool mute = !quick_target->button.get_active();

// pretend the mixer control is the source of the change to prevent a popup
objects_to_controls[quick_target->object]->ignore = true;
// still set visual state
objects_to_controls[quick_target->object]->set_btn_status_no_callbk(mute);
quick_target->set_btn_status_no_callbk(mute);
WpCommon::get().set_mute(id, mute);
};

if (str_wp_left_click_action.value() == "show_mixer")
Expand Down