Repository navigation
Tenet audit fixes; timed_sequence becomes item; key_id; repeated events; time and acceleration calculations - #87
Merged
Conversation
The seven subject.type kinds (#84, signed 2026-10-02) are staged with empty nodes like the other bound value sets; #84 did not raise the number because the did-schema gates run this sweep without --enforce, so it surfaced only in DID-matlab's quick gate (VH-Lab/DID-matlab#215). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
…ng parity - humidity reparented under data_type (concrete), with a gate test that fails any value-bearing class outside data_type - T14 value cell includes tolerance (CHANGE 7); T6 cache wording uses input_id - variable/method documentation per T16; relation.method bound like subject_interaction.method; key/condition/method-parameter variable bound like the statement's variable (bound fields 23 -> 31) - product and acquisition_channels promoted to stable Plan section in V_eta_study_plan.md, to sign. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
A compiled program (WormLab) runs on an operating system with no interpreter; the operating system stays required. Plan section added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
…er sign-off Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
The signed generalisation (V_eta_study_plan.md): `item` names one document per key position through the ordered `item_id` edge (any document, not only a stimulus), `value.item` replaces `presentation_order`, and time is a key only when the list needs one. `timed_sequence_manipulation` becomes `item_manipulation`, and a new `item_calculation` leaf carries computed item lists (the nearest-patch-per-frame case). coverage, status board, tenet map, bar2_gap and the migration targets follow the rename. NDI's stimulusPresentationToTimedSequence.m still emits the old names, so both are acknowledged in KNOWN_NON_VETA until the sibling rename lands. Counts re-derived: 218 class names, 224 schema files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
The signed section (V_eta_study_plan.md, "timed_sequence becomes item") says a position with no item is "the body's fill_value when the values are in a body (a track's tens of thousands of frames are)". timed_sequence's value was mustBeNonEmpty, which refuses every item whose values are in a body. Made optional, with a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Three proposals for sign-off (V_eta_study_plan.md): - `key_labels_id` / `labels_from` become `key_id` / `positions_from`, mirroring `value_id`, and the edge may point only at a data_type document (a statement leaf or a standalone value such as the gene list). Nothing wrote it before; T14 gains a bullet on where a key's positions come from. - T2 gains a paragraph on repeated events: one-off -> its own statement; recurring with measurements -> a list statement of onsets plus one statement per quantity keyed by it through key_id; a scheduled protocol -> an item. - `time_calculation` and `acceleration_calculation` leaves, for the Haley import's encounters. Counts re-derived: 220 class names, 226 schema files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
…e and acceleration sign-off Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
October 5, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All signed in
V_eta_study_plan.md(jess, 2026-10-04/05), with the coverage ledger regenerated after each sign-off.1. Unminted-term baseline 86 → 93. PR #84 bound
subject.typeto seven kinds with empty ontology nodes but didn't raise the baseline, which turned DID-matlab's quick gate red.2. Tenet audit fixes
humidityis a concretedata_type, with a test that any class carrying a value is one.tolerance.input_id.variableandmethodare documented per T16.relation.methodand thevariableof keys, conditions and method parameters are bound like a statement's ownvariable.productandacquisition_channelsare promoted to stable.3.
interpreter_idis optional;operating_system_idstays required.4.
timed_sequencebecomesitemitem_idmay point at any document.value.itemreplacespresentation_order.item_manipulationanditem_calculation.valueis optional, so the values can sit in a body.5.
key_idkey_labels_id/labels_fromare renamedkey_id/positions_from, mirroringvalue_id.data_typedocument.6. Repeated events. T2 gains a paragraph:
item.7.
time_calculationandacceleration_calculation, for the Haley import's encounters.Counts re-derived: 220 class names, 226 schema files. All 28
tools/gates.pysteps pass.Follow-ups elsewhere:
key_id/positions_from.timed_sequenceemitters in DID-matlab and NDI-matlab are acknowledged inKNOWN_NON_VETAuntil those repositories rename them.🤖 Generated with Claude Code
https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf