Skip to content

Fix: Growth Alert (Inline) N+1 database queries on WooCommerce shop/archive pages #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZebaAfiaShama wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

Fix: Growth Alert (Inline) N+1 database queries on WooCommerce shop/archive pages #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions includes/Features/Inline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ class Inline {

public $notifications_data = [];

/**
* Request-level cache of notifications data, keyed by source.
* Inline hooks fire once per product in shop/archive loops; the
* result only varies by $source, so compute it once per request.
*
* @var array
*/
protected $notifications_cache = [];

/**
* __construct__ is for revoke first time to get ready
*
Expand All @@ -35,33 +44,37 @@ public function __construct() {


public function get_notifications_data( $source, $id = null, $settings = [] ) {

$exit = apply_filters('nx_inline_notifications_data', null, $source, $id, $settings);
if($exit){
return $exit;
}

// if ( empty( $this->notifications_data ) ) {
$this->notifications_data = array( 'shortcode' => array() );
$notifications = PostType::get_instance()->get_posts(
if ( ! isset( $this->notifications_cache[ $source ] ) ) {
$data = array( 'shortcode' => array() );
$notifications = PostType::get_instance()->get_posts(
array(
'source' => $source,
'enabled' => true,
'is_inline' => true,
)
);

do_action( 'nx_inline' );

if ( ! empty( $notifications ) ) {
$this->notifications_data = FrontEnd::get_instance()->get_notifications_data(
$data = FrontEnd::get_instance()->get_notifications_data(
array(
'shortcode' => array_column( $notifications, 'nx_id' ),
'inline_shortcode' => true,
)
);
}
// }

$this->notifications_cache[ $source ] = $data;
}

$this->notifications_data = $this->notifications_cache[ $source ];
return $this->notifications_data;
}

Expand Down